Moving ATF tools code into the NetBSD tree

[Julio Merino]

Hello all,

As you know, the ATF tools have been deprecated for a long while and
the intention has been to replace them with Kyua. Unfortunately, that
hasn't happened yet due to a couple of issues in Kyua that need
addressing to satisfy the continuous testing machines' desires. (The
requests are reasonable but I just haven't had the energy to address
them...)

I have (finally) gained interest again in addressing these issues and
started working on a solution. But, in the meantime and because that
won't be trivial, I'd like to kiss goodbye to the deprecated ATF tools
to simplify the maintenance of the upstream code and, especially, to
make my packaging tasks for the various systems involved much simpler.

For this reason, I am considering the removal of the ATF tools code
from the upstream distfile, removing the code from external/bsd/atf/
and *moving* a copy of the deleted code into the non-external
directories.

For example, atf-run's master code would move from
external/bsd/atf/atf-run/ to usr.bin/atf-run/ (and still remain
conditional on the MK_KYUA knob).

The implication of this move is the transfer of maintainership of the
deprecated tools to the NetBSD project.

Somehow I think this is a good thing because I get the the impression
that some people around here really want to tweak the ATF tools until
Kyua is ready -- and the fact that the code lives in external may have
been a detriment to doing so.

How does that sound?

I'd still like to request up-front discussion of changes to the code
before doing anything intrusive, but doing simpler changes would be
easier than it is today: no need to wait for upstream releases or
having to worry too much about other platforms.

Thank you.

[Matt Thomas]

Post by Julio Merino
Hello all,
As you know, the ATF tools have been deprecated for a long while and
the intention has been to replace them with Kyua. Unfortunately, that
hasn't happened yet due to a couple of issues in Kyua that need
addressing to satisfy the continuous testing machines' desires. (The
requests are reasonable but I just haven't had the energy to address
them...)
I have (finally) gained interest again in addressing these issues and
started working on a solution. But, in the meantime and because that
won't be trivial, I'd like to kiss goodbye to the deprecated ATF tools
to simplify the maintenance of the upstream code and, especially, to
make my packaging tasks for the various systems involved much simpler.
For this reason, I am considering the removal of the ATF tools code
from the upstream distfile, removing the code from external/bsd/atf/
and *moving* a copy of the deleted code into the non-external
directories.
For example, atf-run's master code would move from
external/bsd/atf/atf-run/ to usr.bin/atf-run/ (and still remain
conditional on the MK_KYUA knob).
The implication of this move is the transfer of maintainership of the
deprecated tools to the NetBSD project.
Somehow I think this is a good thing because I get the the impression
that some people around here really want to tweak the ATF tools until
Kyua is ready -- and the fact that the code lives in external may have
been a detriment to doing so.
How does that sound?

Wrong. We already keep local maintained stuff in external (netpgp).
So just leave it where it is. kyua will be going someplcae else so
it just churn for no good reason.

[Julio Merino]

Post by Matt Thomas

Post by Julio Merino
Hello all,
As you know, the ATF tools have been deprecated for a long while and
the intention has been to replace them with Kyua. Unfortunately, that
hasn't happened yet due to a couple of issues in Kyua that need
addressing to satisfy the continuous testing machines' desires. (The
requests are reasonable but I just haven't had the energy to address
them...)
I have (finally) gained interest again in addressing these issues and
started working on a solution. But, in the meantime and because that
won't be trivial, I'd like to kiss goodbye to the deprecated ATF tools
to simplify the maintenance of the upstream code and, especially, to
make my packaging tasks for the various systems involved much simpler.
For this reason, I am considering the removal of the ATF tools code
from the upstream distfile, removing the code from external/bsd/atf/
and *moving* a copy of the deleted code into the non-external
directories.
For example, atf-run's master code would move from
external/bsd/atf/atf-run/ to usr.bin/atf-run/ (and still remain
conditional on the MK_KYUA knob).
The implication of this move is the transfer of maintainership of the
deprecated tools to the NetBSD project.
Somehow I think this is a good thing because I get the the impression
that some people around here really want to tweak the ATF tools until
Kyua is ready -- and the fact that the code lives in external may have
been a detriment to doing so.
How does that sound?

Wrong. We already keep local maintained stuff in external (netpgp).

But does that make sense, conceptually? Why keep it there if it's not
external any more?

Or is it just, again, coping within CVS's annoyances?

Post by Matt Thomas
So just leave it where it is. kyua will be going someplcae else so
it just churn for no good reason.

[Matt Thomas]

Post by Julio Merino

Post by Matt Thomas

Post by Julio Merino
Hello all,
As you know, the ATF tools have been deprecated for a long while and
the intention has been to replace them with Kyua. Unfortunately, that
hasn't happened yet due to a couple of issues in Kyua that need
addressing to satisfy the continuous testing machines' desires. (The
requests are reasonable but I just haven't had the energy to address
them...)
I have (finally) gained interest again in addressing these issues and
started working on a solution. But, in the meantime and because that
won't be trivial, I'd like to kiss goodbye to the deprecated ATF tools
to simplify the maintenance of the upstream code and, especially, to
make my packaging tasks for the various systems involved much simpler.
For this reason, I am considering the removal of the ATF tools code
from the upstream distfile, removing the code from external/bsd/atf/
and *moving* a copy of the deleted code into the non-external
directories.
For example, atf-run's master code would move from
external/bsd/atf/atf-run/ to usr.bin/atf-run/ (and still remain
conditional on the MK_KYUA knob).
The implication of this move is the transfer of maintainership of the
deprecated tools to the NetBSD project.
Somehow I think this is a good thing because I get the the impression
that some people around here really want to tweak the ATF tools until
Kyua is ready -- and the fact that the code lives in external may have
been a detriment to doing so.
How does that sound?

Wrong. We already keep local maintained stuff in external (netpgp).

But does that make sense, conceptually? Why keep it there if it's not
external any more?

Yes it does. external is a way of modularizing the source tree.
For something like atf, which is reasonably self-contained, keeping
it like that is just fine. It also make its removal easier once kyua
it ready to replace it.

[Christos Zoulas]

Post by Matt Thomas
Yes it does. external is a way of modularizing the source tree.
For something like atf, which is reasonably self-contained, keeping
it like that is just fine. It also make its removal easier once kyua
it ready to replace it.

I concur, the amount of patching or who maintains it does not determine
the code placement; for example think about pdisk.

christos